Skip to content

Remove SmartContractController (downgraded to a mere test utility) #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 8, 2022
Merged

Remove SmartContractController (downgraded to a mere test utility) #188

merged 11 commits into from
Apr 8, 2022

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Apr 8, 2022

  • Removed SmartContractController (downgraded to a mere test utility).
  • One should explicitly send the transaction, await for its completion, then parse the results.

If desired, one can replicate a controller in the dApp, as seen in:

  • src/testutils/contractController.ts

@andreibancioiu andreibancioiu changed the base branch from main to methods-auto April 8, 2022 11:24
@andreibancioiu andreibancioiu self-assigned this Apr 8, 2022
Base automatically changed from methods-auto to main April 8, 2022 12:12
@andreibancioiu andreibancioiu merged commit b373c59 into main Apr 8, 2022
@andreibancioiu andreibancioiu deleted the simplify-or-remove-controller branch April 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

+1 more reviewer

@claudiu725 claudiu725 claudiu725 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andreibancioiu andreibancioiu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreibancioiu @claudiu725 @bogdan-rosianu