Breaking changes: cleanup and minor improvements prior release (step 1) #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge not recommended).
…y of our signing providers).
… deploy transaction - not applicable when using our signing providers, anyway).
…t in walletcore).
andreibancioiu
changed the title
bogdan-rosianu
previously approved these changes
Apr 11, 2022
ccorcoveanu
reviewed
Apr 11, 2022
src/smartcontracts/interface.ts
Outdated
| * Gets the address of the Smart Contract. | ||
| */ | ||
| getAddress(): Address; | ||
| getAddress(): IBech32Address; |
Contributor
There was a problem hiding this comment.
Q - why do we have IBech32 as opposed to an interface for the address?
Contributor
Author
There was a problem hiding this comment.
It was named this way in order to avoid an eventual ambiguity. That is, IBech32Address only has the bech32() method, without pubkey() and hex(), thus being a bit more "portable" between different domains (e.g. walletcore, network-providers and so on) - some of which don't know how to encode / decode an address.
We can change this, though. IAddress?
Contributor
Author
There was a problem hiding this comment.
Renamed to IAddress.
ccorcoveanu
previously approved these changes
Apr 11, 2022
bogdan-rosianu
previously approved these changes
Apr 11, 2022
ccorcoveanu
previously approved these changes
Apr 11, 2022
andreibancioiu
dismissed stale reviews from ccorcoveanu and bogdan-rosianu
via
305ba50
bogdan-rosianu
approved these changes
Apr 11, 2022
ccorcoveanu
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axiosandfsanymore. Changed the way anAbiRegistryis created. Removed functionCode.fromFile()(was relying onfs).boundaryAdapters(simplification).smartContract.getOwner()(surprising behavior of function, usage not recommended).ErrTransactionNotSigned).transaction.awaitHashed()(lacks use-case).transaction.awaitSigned()(it isn't useful in relation with any of our signing providers).ISignableis not needed in erdjs, but in walletcore).contract.code,contract.codeMetadata.interaction.getContract(). Addinteraction.getContractAddress().IResultsParser.Code.nothing().