Skip to content

Breaking changes: cleanup and minor improvements prior release (step 2) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 11, 2022
Merged

Breaking changes: cleanup and minor improvements prior release (step 2) #191

merged 13 commits into from
Apr 11, 2022

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Apr 10, 2022 •
edited
Loading

  • Move query.toHttpRequest() logic to network-providers.
  • Simplifications wrt. integration with network providers (in integration tests).
  • Reference newer network-providers (dev-dependency).
  • Use interface for address in interaction.
  • Remove interaction.withGasLimitComponents(). Not so helpful anymore (since NetworkConfig isn't a singleton anymore).

@andreibancioiu andreibancioiu self-assigned this Apr 10, 2022
bogdan-rosianu
bogdan-rosianu previously approved these changes Apr 11, 2022
View reviewed changes
Base automatically changed from improvements-01 to main April 11, 2022 12:50
@andreibancioiu andreibancioiu merged commit 996b152 into main Apr 11, 2022
@andreibancioiu andreibancioiu deleted the improvements-02 branch April 11, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccorcoveanu ccorcoveanu ccorcoveanu approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreibancioiu @ccorcoveanu @bogdan-rosianu