Skip to content

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Apr 10, 2022

  • Decouple (somehow) Balance from Token.
  • Prepare new beta pre-release.

@andreibancioiu andreibancioiu self-assigned this Apr 10, 2022
bogdan-rosianu
bogdan-rosianu previously approved these changes Apr 11, 2022
};
}

// TODO: We should not keep a property of a token instance (its nonce) here, in the "Tokens" (still called "Balance") class.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I think the number of decimals has to be passed as well into this component, if we want to use it for different tokens

Base automatically changed from improvements-02 to main April 11, 2022 13:16
@andreibancioiu andreibancioiu changed the title Breaking changes: cleanup and minor improvements prior release (step 3) Prepare new beta pre-release Apr 11, 2022
@andreibancioiu andreibancioiu merged commit 739c311 into main Apr 11, 2022
@andreibancioiu andreibancioiu deleted the improvements-03 branch April 11, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants