Add account awaiter #559
Merged
Add account awaiter #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
reviewed
Jan 21, 2025
Contributor
There was a problem hiding this comment.
filename contains 2 consecutive dots.
Comment on lines
15
to
18
| private fetcher: IAccountFetcher; | ||
| private pollingIntervalInMilliseconds: number; | ||
| private timeoutIntervalInMilliseconds: number; | ||
| private patienceTimeInMilliseconds: number; |
Contributor
There was a problem hiding this comment.
Maybe can also be "readonly".
Comment on lines
+81
to
+83
| } catch (ex) { | ||
| throw ex; | ||
| } |
Contributor
There was a problem hiding this comment.
Is this what we want?
Contributor
Author
There was a problem hiding this comment.
this is what we are doing on the transaction watcher also..
Contributor
There was a problem hiding this comment.
All right then for now. We should check if that's the best approach - for both of them (separately, another task / PR).
andreibancioiu
approved these changes
Jan 21, 2025
popenta
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.