Tool 431 add missing function on token management controller #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
previously approved these changes
Jan 23, 2025
| private getOutputForESDTSetNewURIsEvent(event: TransactionEvent): SetNewUrisOutput { | ||
| const tokenIdentifier = this.extractTokenIdentifier(event); | ||
| const nonce = this.extractNonce(event); | ||
| const uri = !event.topics[3]?.length ? "" : event.topics[3].toString(); |
Contributor
There was a problem hiding this comment.
I find it a bit strange to have not (!) before the condition :) Not a big deal nonetheless.
popenta
approved these changes
Jan 23, 2025
andreibancioiu
approved these changes
Jan 23, 2025
Comment on lines
+121
to
+123
| export type SetNewUrisOutput = { tokenIdentifier: string; nonce: bigint; uri: string }; | ||
| export type ModifyingCreatorOutput = { tokenIdentifier: string; nonce: bigint }; | ||
| export type UpdateAttibutesOutput = { tokenIdentifier: string; nonce: bigint; metadata: Uint8Array }; |
Contributor
There was a problem hiding this comment.
Bit of naming inconsistency - modify vs. modifying, update vs. updating. Which one should we pick?
danielailie
deleted the
TOOL-431-add-missing-function-on-token-management-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.