Skip to content

Add implementation for missing methods on delegation factory #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add implementation for missing methods on delegation factory #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1cba5
Add implementation for missing methods on delegation factory
danielailie Jan 23, 2025
91e4750
Add new line
danielailie Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 101 additions & 11 deletions src/delegation/delegationTransactionsFactory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe("test delegation transactions factory", function () {
const delegationFactory = new DelegationTransactionsFactory({ config: config });

it("should create 'Transaction' for new delegation contract", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delagationCap = 5000000000000000000000n;
const serviceFee = 10n;
const value = 1250000000000000000000n;
Expand All @@ -37,7 +37,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for adding nodes", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);
const publicKey = new ValidatorPublicKey(
Buffer.from(
Expand Down Expand Up @@ -76,7 +76,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for removing nodes", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const publicKey = new ValidatorPublicKey(
Expand Down Expand Up @@ -106,7 +106,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for staking nodes", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);
const publicKey = new ValidatorPublicKey(
Buffer.from(
Expand Down Expand Up @@ -135,7 +135,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for unbonding nodes", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);
const publicKey = new ValidatorPublicKey(
Buffer.from(
Expand Down Expand Up @@ -165,7 +165,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for unstaking nodes", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);
const publicKey = new ValidatorPublicKey(
Buffer.from(
Expand Down Expand Up @@ -244,7 +244,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for changing delegation cap", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);
const delegationCap = 5000000000000000000000n;

Expand All @@ -264,7 +264,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for setting automatic activation", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForSettingAutomaticActivation(sender, {
Expand All @@ -282,7 +282,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for unsetting automatic activation", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForUnsettingAutomaticActivation(sender, {
Expand All @@ -300,7 +300,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for setting cap check on redelegate rewards", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForSettingCapCheckOnRedelegateRewards(sender, {
Expand All @@ -318,7 +318,7 @@ describe("test delegation transactions factory", function () {
});

it("should create 'Transaction' for unsetting cap check on redelegate rewards", async function () {
const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForUnsettingCapCheckOnRedelegateRewards(sender, {
Expand Down Expand Up @@ -355,4 +355,94 @@ describe("test delegation transactions factory", function () {
assert.deepEqual(transaction.data, Buffer.from("setMetaData@6e616d65@77656273697465@6964656e746966696572"));
assert.equal(transaction.value, 0n);
});

it("should create 'Transaction' for delegating", async function () {
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForDelegating(sender, {
delegationContract: delegationContract,
amount: 1000000000000000000n,
});

assert.deepEqual(
transaction.sender,
Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2"),
);
assert.deepEqual(transaction.receiver, Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX));
assert.isDefined(transaction.data);
assert.deepEqual(transaction.data, Buffer.from("delegate"));
assert.equal(transaction.value, 1000000000000000000n);
});

it("should create 'Transaction' for claiming rewards", async function () {
Copy link
Contributor

@popenta popenta Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an empty line

const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForClaimingRewards(sender, {
delegationContract: delegationContract,
});

assert.deepEqual(
transaction.sender,
Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2"),
);
assert.deepEqual(transaction.receiver, Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX));
assert.isDefined(transaction.data);
assert.deepEqual(transaction.data, Buffer.from("claimRewards"));
});

it("should create 'Transaction' for redelegating rewards", async function () {
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForRedelegatingRewards(sender, {
delegationContract: delegationContract,
});

assert.deepEqual(
transaction.sender,
Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2"),
);
assert.deepEqual(transaction.receiver, Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX));
assert.isDefined(transaction.data);
assert.deepEqual(transaction.data, Buffer.from("reDelegateRewards"));
});

it("should create 'Transaction' for undelegating", async function () {
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForUndelegating(sender, {
delegationContract: delegationContract,
amount: 1000000000000000000n,
});

assert.deepEqual(
transaction.sender,
Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2"),
);
assert.deepEqual(transaction.receiver, Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX));
assert.isDefined(transaction.data);
assert.deepEqual(transaction.data, Buffer.from("unDelegate@0de0b6b3a7640000"));
assert.equal(transaction.value, 0n);
});

it("should create 'Transaction' for withdrawing", async function () {
const sender = Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
const delegationContract = Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX);

const transaction = delegationFactory.createTransactionForWithdrawing(sender, {
delegationContract: delegationContract,
});

assert.deepEqual(
transaction.sender,
Address.newFromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2"),
);
assert.deepEqual(transaction.receiver, Address.newFromHex(DELEGATION_MANAGER_SC_ADDRESS_HEX));
assert.isDefined(transaction.data);
assert.deepEqual(transaction.data, Buffer.from("withdraw"));
assert.equal(transaction.value, 0n);
});
});
84 changes: 70 additions & 14 deletions src/delegation/delegationTransactionsFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,30 +333,86 @@ export class DelegationTransactionsFactory {
}).build();
}

createTransactionForWithdrawing(_sender: Address, _options: resources.ManageDelegationContractInput): Transaction {
throw new Error("Method not implemented.");
createTransactionForDelegating(sender: Address, options: resources.DelegateActionsInput): Transaction {
const dataParts = ["delegate"];
const gasLimit =
this.config.gasLimitDelegationOperations + this.config.additionalGasLimitForDelegationOperations;

return new TransactionBuilder({
config: this.config,
sender: sender,
receiver: options.delegationContract,
dataParts: dataParts,
gasLimit: gasLimit,
amount: options.amount,
addDataMovementGas: false,
}).build();
}

createTransactionForUndelegating(_sender: Address, _options: resources.DelegateActionsInput): Transaction {
throw new Error("Method not implemented.");
createTransactionForClaimingRewards(
sender: Address,
options: resources.ManageDelegationContractInput,
): Transaction {
const dataParts = ["claimRewards"];
const gasLimit =
this.config.gasLimitDelegationOperations + this.config.additionalGasLimitForDelegationOperations;

return new TransactionBuilder({
config: this.config,
sender: sender,
receiver: options.delegationContract,
dataParts: dataParts,
gasLimit: gasLimit,
addDataMovementGas: false,
}).build();
}

createTransactionForRedelegatingRewards(
_sender: Address,
_options: resources.ManageDelegationContractInput,
sender: Address,
options: resources.ManageDelegationContractInput,
): Transaction {
throw new Error("Method not implemented.");
const dataParts = ["reDelegateRewards"];
const gasLimit =
this.config.gasLimitDelegationOperations + this.config.additionalGasLimitForDelegationOperations;

return new TransactionBuilder({
config: this.config,
sender: sender,
receiver: options.delegationContract,
dataParts: dataParts,
gasLimit: gasLimit,
addDataMovementGas: false,
}).build();
}

createTransactionForClaimingRewards(
_sender: Address,
_options: resources.ManageDelegationContractInput,
): Transaction {
throw new Error("Method not implemented.");
createTransactionForUndelegating(sender: Address, options: resources.DelegateActionsInput): Transaction {
const dataParts = ["unDelegate", this.argSerializer.valuesToStrings([new BigUIntValue(options.amount)])[0]];
const gasLimit =
this.config.gasLimitDelegationOperations + this.config.additionalGasLimitForDelegationOperations;

return new TransactionBuilder({
config: this.config,
sender: sender,
receiver: options.delegationContract,
dataParts: dataParts,
gasLimit: gasLimit,
addDataMovementGas: false,
}).build();
}

createTransactionForDelegating(_sender: Address, _options: resources.DelegateActionsInput): Transaction {
throw new Error("Method not implemented.");
createTransactionForWithdrawing(sender: Address, options: resources.ManageDelegationContractInput): Transaction {
const dataParts = ["withdraw"];
const gasLimit =
this.config.gasLimitDelegationOperations + this.config.additionalGasLimitForDelegationOperations;

return new TransactionBuilder({
config: this.config,
sender: sender,
receiver: options.delegationContract,
dataParts: dataParts,
gasLimit: gasLimit,
addDataMovementGas: false,
}).build();
}

private computeExecutionGasLimitForNodesManagement(numNodes: number): bigint {
Expand Down
Loading