Skip to content

Allow passing network options from Entrypoint to Network Provider #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 28, 2025
Merged

Allow passing network options from Entrypoint to Network Provider #652

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d23fe6c
Allow passing network options from Entrypoint to Network Provider
BubuMVX Aug 5, 2025
45bf412
Rename networkProviderOptions to networkProviderConfig in NetworkEntr…
BubuMVX Aug 11, 2025
0966d5a
Use immutable approach for network provider config in NetworkEntrypoint
BubuMVX Aug 11, 2025
e57fe27
Merge branch 'main' of https://github.com/BubuMVX/mx-sdk-js-core into…
BubuMVX Aug 11, 2025
0098f8b
Rename networkProviderOptions to networkProviderConfig for consistency
BubuMVX Aug 13, 2025
d0cc0c4
Merge branch 'main' into feat/entrypoint-network-provider-options
popenta Aug 28, 2025
08658b2
Merge branch 'main' into feat/entrypoint-network-provider-options
popenta Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/entrypoints/entrypoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { GasLimitEstimator } from "../gasEstimator";
import { GovernanceController, GovernanceTransactionsFactory } from "../governance";
import { MultisigTransactionsFactory } from "../multisig";
import { MultisigController } from "../multisig/multisigController";
import { ApiNetworkProvider, ProxyNetworkProvider } from "../networkProviders";
import { ApiNetworkProvider, NetworkProviderConfig, ProxyNetworkProvider } from "../networkProviders";
import { INetworkProvider } from "../networkProviders/interface";
import { SmartContractTransactionsFactory } from "../smartContracts";
import { SmartContractController } from "../smartContracts/smartContractController";
Expand All @@ -34,19 +34,21 @@ export class NetworkEntrypoint {
constructor(options: {
networkProviderUrl: string;
networkProviderKind: string;
networkProviderConfig?: NetworkProviderConfig;
chainId: string;
clientName?: string;
withGasLimitEstimator?: boolean;
gasLimitMultiplier?: number;
}) {
const networkProviderConfig: NetworkProviderConfig = {
...(options.networkProviderConfig ?? {}),
...(options.clientName && { clientName: options.clientName }),
};

if (options.networkProviderKind === "proxy") {
this.networkProvider = new ProxyNetworkProvider(options.networkProviderUrl, {
clientName: options.clientName,
});
this.networkProvider = new ProxyNetworkProvider(options.networkProviderUrl, networkProviderConfig);
} else if (options.networkProviderKind === "api") {
this.networkProvider = new ApiNetworkProvider(options.networkProviderUrl, {
clientName: options.clientName,
});
this.networkProvider = new ApiNetworkProvider(options.networkProviderUrl, networkProviderConfig);
} else {
throw new ErrInvalidNetworkProviderKind();
}
Expand Down Expand Up @@ -267,12 +269,14 @@ export class TestnetEntrypoint extends NetworkEntrypoint {
clientName?: string;
withGasLimitEstimator?: boolean;
gasLimitMultiplier?: number;
networkProviderConfig?: NetworkProviderConfig;
}) {
const entrypointConfig = new TestnetEntrypointConfig();
options = options || {};
super({
networkProviderUrl: options.url || entrypointConfig.networkProviderUrl,
networkProviderKind: options.kind || entrypointConfig.networkProviderKind,
networkProviderConfig: options.networkProviderConfig,
chainId: entrypointConfig.chainId,
clientName: options.clientName,
withGasLimitEstimator: options.withGasLimitEstimator,
Expand All @@ -288,12 +292,14 @@ export class DevnetEntrypoint extends NetworkEntrypoint {
clientName?: string;
withGasLimitEstimator?: boolean;
gasLimitMultiplier?: number;
networkProviderConfig?: NetworkProviderConfig;
}) {
const entrypointConfig = new DevnetEntrypointConfig();
options = options || {};
super({
networkProviderUrl: options.url || entrypointConfig.networkProviderUrl,
networkProviderKind: options.kind || entrypointConfig.networkProviderKind,
networkProviderConfig: options.networkProviderConfig,
chainId: entrypointConfig.chainId,
clientName: options.clientName,
withGasLimitEstimator: options.withGasLimitEstimator,
Expand All @@ -309,12 +315,14 @@ export class MainnetEntrypoint extends NetworkEntrypoint {
clientName?: string;
withGasLimitEstimator?: boolean;
gasLimitMultiplier?: number;
networkProviderConfig?: NetworkProviderConfig;
}) {
const entrypointConfig = new MainnetEntrypointConfig();
options = options || {};
super({
networkProviderUrl: options.url || entrypointConfig.networkProviderUrl,
networkProviderKind: options.kind || entrypointConfig.networkProviderKind,
networkProviderConfig: options.networkProviderConfig,
chainId: entrypointConfig.chainId,
clientName: options.clientName,
withGasLimitEstimator: options.withGasLimitEstimator,
Expand Down
Loading