Repository migration fixes#175
Conversation
| go_mod = testnet_config.node_source() / "go.mod" | ||
| lines = utils.read_lines(go_mod) | ||
| line = next(line for line in lines if "github.com/ElrondNetwork/arwen-wasm-vm" in line) | ||
| line = next(line for line in lines if "github.com/ElrondNetwork/wasm-vm" in line) |
There was a problem hiding this comment.
[optional] should maybe also switch to the new repo?
There was a problem hiding this comment.
Unfortunately, this depends on go.mod:
https://github.com/multiversx/mx-chain-go/blob/master/go.mod
Thus, we have to actually use the oldest name (please revert this change).
There was a problem hiding this comment.
Reverted to old name
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| echo " - [CHANGELOG](https://github.com/ElrondNetwork/elrond-sdk-erdpy/blob/main/erdpy/CHANGELOG.md)" >> notes.txt | ||
| echo " - [CHANGELOG](https://github.com/multiversx/mx-sdk-erdpy/blob/main/erdpy/CHANGELOG.md)" >> notes.txt |
There was a problem hiding this comment.
Remove this link (since changelog has been removed). Actually, remove usage of notes.txt all-together?
|
|
||
| ## Distribution | ||
| [erdpy-up](https://docs.elrond.com/sdk-and-tools/erdpy/installing-erdpy/) and [PyPi](https://pypi.org/project/erdpy/#history) | ||
| [erdpy-up](https://docs.multiversx.com/sdk-and-tools/erdpy/installing-erdpy/) and [PyPi](https://pypi.org/project/erdpy/#history) |
There was a problem hiding this comment.
The section below (changelog) can be removed.
|
|
||
| def remove_installation(): | ||
| old_folder = os.path.expanduser("~/ElrondSCTools") | ||
| def migrate_installation(sdk_path: str) -> None: |
There was a problem hiding this comment.
👍 we will call this method in a future release.
| logger.info(""" | ||
|
|
||
| For more information go to https://docs.elrond.com. | ||
| For more information go to https://docs.multiversx.com. |
There was a problem hiding this comment.
The Telegram group has to be renamed as well (but not now, I think).
There was a problem hiding this comment.
I don't know if it's been renamed.
| @@ -1,16 +1,16 @@ | |||
| # Description | |||
| Elrond Python Command Line Tools and SDK for interacting with the Elrond Network (in general) and Smart Contracts (in particular). | |||
| MultiversX Python Command Line Tools and SDK for interacting with the MultiversX Network (in general) and Smart Contracts (in particular). | |||
There was a problem hiding this comment.
Only now I see that there are 2 readme files. Remove this one, and update the one at the top level?
There was a problem hiding this comment.
Deleted this file and update the one at the top level.
| def is_template(self, subfolder: str) -> bool: | ||
| elrond_json_file = self.get_metadata_file(subfolder) | ||
| return elrond_json_file.is_file() | ||
| multiversx_json_file = self.get_metadata_file(subfolder) |
There was a problem hiding this comment.
Can be renamed to project_config_file, perhaps.
|
|
||
| def proxy_source(self) -> Path: | ||
| return self.folders['elrond_proxy_go'] | ||
| return self.folders['max_chain_proxy_go'] |
| # Now copy the binaries to the testnet folder | ||
| wasm_vm_version = _get_wasm_vm_version(testnet_config) | ||
| libwasmer_path = path.join(golang.get_gopath(), f"pkg/mod/github.com/!elrond!network/arwen-wasm-vm@{wasm_vm_version}/wasmer/libwasmer_darwin_amd64.dylib") | ||
| libwasmer_path = path.join(golang.get_gopath(), f"pkg/mod/github.com/!elrond!network/wasm-vm@{wasm_vm_version}/wasmer/libwasmer_darwin_amd64.dylib") |
There was a problem hiding this comment.
Please revert (arwen-wasm-vm, as it is in go.mod).
| BIP39_PBKDF2_ROUNDS = 2048 | ||
| BIP32_SEED_MODIFIER = b'ed25519 seed' | ||
| ELROND_DERIVATION_PATH = [44, 508, 0, 0] | ||
| MULTIVERSX_DERIVATION_PATH = [44, 508, 0, 0] |
There was a problem hiding this comment.
Can be HD_WALLET_DERIVATION_PATH or BIP39_WALLET_DERIVATION_PATH.
There was a problem hiding this comment.
Changed to BIP39_WALLET_DERIVATION_PATH
| name="erdpy", | ||
| version=VERSION, | ||
| description="Elrond Smart Contracts Tools and Python SDK", | ||
| description="MultiversX Smart Contracts Tools and Python SDK", |
There was a problem hiding this comment.
Remove and Python SDK (since now we have the "eggs" libraries).
3 participants
This PR aims to solve the issues created by the migration of the repositories to the new organization.
The word
elrondstill exists in the repository, mostly used forElrondProxy, the integration oferdpy-network-providerswill come inv4.0.0. There are some other places where the word is used, but the changes will be breaking changes, will come in a later PR, probably after the migration is complete.Deleted the docs folder and the examples folder because we have the erdpy cookbook (https://github.com/multiversx/mx-sdk-erdpy-examples).