Skip to content

Rebranding for CLI.md file#180

Merged
popenta merged 3 commits into
feat/v4from
rebrand-cli
Jan 12, 2023
Merged

Rebranding for CLI.md file#180
popenta merged 3 commits into
feat/v4from
rebrand-cli

Conversation

@popenta
Copy link
Copy Markdown
Collaborator

@popenta popenta commented Jan 12, 2023

No description provided.

@popenta popenta self-assigned this Jan 12, 2023
@popenta popenta changed the base branch from main to feat/v4 January 12, 2023 12:15
Comment thread .github/workflows/build-macos.yml Outdated
@@ -1,4 +1,4 @@
name: Install erdpy using erdpy-up (MacOS)
name: Install mxpy using erdpy-up (MacOS)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so erdpy-up will remain?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted it.

andreibancioiu
andreibancioiu previously approved these changes Jan 12, 2023
@@ -1,4 +1,4 @@
name: Install erdpy using erdpy-up (Ubuntu)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without "using erdpy-up", but can be removed in another PR.

Comment thread erdpy/cli.py Outdated
parser._optionals.title = "TOP-LEVEL OPTIONS"

parser.add_argument("-v", "--version", action="version", version=f"erdpy {__version__}")
parser.add_argument("-v", "--version", action="version", version=f"mxpy {__version__}")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say: MultiversX Python CLI (mxpy) ....

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in the next PR.

Comment thread .github/workflows/install.yml Outdated
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: erdpy-build
name: mxpy-build
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the workflows files, we can simply remove mxpy- as well, and only leave build: etc.

Comment thread .github/workflows/build-ubuntu.yml Outdated

jobs:
install-erdpy:
install-mxpy:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be just install:.

Comment thread .github/workflows/install.yml Outdated
jobs:
build-erdpy:
name: Build and Test erdpy for ${{ matrix.os }}, python ${{ matrix.python-version }}
build-mxpy:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be build:.

Comment thread .github/workflows/build-macos.yml Outdated
@@ -1,4 +1,4 @@
name: Install erdpy using erdpy-up (MacOS)
name: Install mxpy using erdpy-up (MacOS)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be Install (MacOS).

Comment thread .github/workflows/build-macos.yml Outdated

jobs:
install-erdpy:
install-mxpy:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be install:.

@popenta popenta merged commit acb19fe into feat/v4 Jan 12, 2023
@popenta popenta deleted the rebrand-cli branch January 12, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants