Refactored accounts to use the ones from sdk-py#477
Merged
Conversation
andreibancioiu
approved these changes
Feb 7, 2025
Contributor
andreibancioiu
left a comment
andreibancioiu
left a comment
There was a problem hiding this comment.
Nice refactoring and cleanup!
In a separate PR, can we handle [mypy] reported by reviewdog 🐶 warnings?
| "--address-index", | ||
| type=int, | ||
| default=None, | ||
| help="🔑 the index of the address in the keyfile; should only be provided for keyfile of kind = mnemonic", |
| help="🔑 a file containing keyfile's password, if keyfile provided", | ||
| ) | ||
| sub.add_argument( | ||
| "--guardian-address-index", |
Contributor
There was a problem hiding this comment.
As discussed, in the future, --*-address-index can absorb --guardian-ledger-account-index and the similar ones etc.
Collaborator
Author
There was a problem hiding this comment.
Will do in the future.
Collaborator
Author
Will do in a separate PR. |
bogdan-rosianu
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.