Validators transactions refactoring#479
Conversation
There was a problem hiding this comment.
🚀
By the way, can we somehow get rid of the mypy warning?
[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found]
There was a problem hiding this comment.
I've modified the GH action, should be fine now.
|
|
||
|
|
||
| def _read_stdout(capsys: Any) -> str: | ||
| return capsys.readouterr().out.strip() |
|
|
||
|
|
||
| def _read_stdout(capsys: Any) -> str: | ||
| return capsys.readouterr().out.strip() |
| UNSTAKE_TOKENS = 5000000 | ||
| UNBOND_TOKENS = 5000000 | ||
| CLEAN_REGISTERED_DATA = 5000000 | ||
| RE_STAKE_UNSTAKED_NODES = 5000000 |
There was a problem hiding this comment.
Restake can be considered as being a single word.
There was a problem hiding this comment.
A bit verbose.
Can we have a function that encapsulates this (optional, anyway)?
if args.nonce is None:
nonce = cli_shared.get_current_nonce_for_address(sender.address, args.proxy)
else:
nonce = int(args.nonce)
guardian = cli_shared.load_guardian_account(args)
guardian_address = cli_shared.get_guardian_address(guardian, args)
relayer = cli_shared.load_relayer_account(args)
relayer_address = cli_shared.get_relayer_address(relayer, args)
There was a problem hiding this comment.
refactored it a bit.
There was a problem hiding this comment.
We don't seem to have the corresponding factory / controller in the SDK and specs. Maybe we can do that (separately, a future PR).
There was a problem hiding this comment.
created a task for it.
popenta
dismissed
andreibancioiu’s stale review
The merge-base changed after approval.
popenta
dismissed stale reviews from danielailie and andreibancioiu
The merge-base changed after approval.
3 participants
No description provided.