Skip to content

Fixed mypy errors#480

Merged
popenta merged 5 commits into
feat/nextfrom
fix-mypy-issues
Feb 10, 2025
Merged

Fixed mypy errors#480
popenta merged 5 commits into
feat/nextfrom
fix-mypy-issues

Conversation

@popenta
Copy link
Copy Markdown
Collaborator

@popenta popenta commented Feb 7, 2025

No description provided.

@popenta popenta self-assigned this Feb 7, 2025
@popenta popenta marked this pull request as draft February 7, 2025 15:49
Base automatically changed from transaction-refactoring to feat/next February 10, 2025 15:06
@popenta popenta marked this pull request as ready for review February 10, 2025 15:07
return address_from_account or address_from_args


def _is_matching_address(account_address: Union[Address, None], args_address: Union[Address, None]) -> bool:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +18 to +19
shards: RegularShards
metashard: Metashard
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move to constructor?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@popenta popenta merged commit 0f77497 into feat/next Feb 10, 2025
@popenta popenta deleted the fix-mypy-issues branch February 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants