Fix get account and get transaction#482
Merged
Merged
Conversation
popenta
force-pushed
the
fix-get-account
branch
from
d931013 to
15ccd39
Compare
| print(account.username) | ||
| else: | ||
| utils.dump_out_json(account.raw) | ||
| account = _account_on_network_to_dictionary(account) |
|
|
||
|
|
||
| def get_account(args: Any): | ||
| omitted_fields = cli_shared.parse_omit_fields_arg(args) |
Contributor
There was a problem hiding this comment.
Though, do we still need this command, or can we drop it (since people can simply get the data from the public API)?
Collaborator
Author
There was a problem hiding this comment.
as decided, we've dropped this command.
|
|
||
|
|
||
| def get_transaction(args: Any): | ||
| if not args.proxy: |
Contributor
There was a problem hiding this comment.
Though, do we still need this command, or can we drop it (since people can simply get the data from the public API)?
Collaborator
Author
There was a problem hiding this comment.
this command has been dropped, as well.
Comment on lines
+170
to
+171
| "gas_limit": tx.gas_limit, | ||
| "gas_price": tx.gas_price, |
Contributor
There was a problem hiding this comment.
Maybe use the "standard" JSON naming conventions / camel-case.
andreibancioiu
approved these changes
Feb 19, 2025
danielailie
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.