Skip to content

Comments

Governance fixes#250

Merged
popenta merged 4 commits intofeat/nextfrom
governance-fix
May 22, 2025
Merged

Governance fixes#250
popenta merged 4 commits intofeat/nextfrom
governance-fix

Conversation

@popenta
Copy link
Collaborator

@popenta popenta commented May 21, 2025

No description provided.

@popenta popenta self-assigned this May 21, 2025
@github-actions
Copy link

github-actions bot commented May 21, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/governance
  governance_controller.py 94, 97-98, 126, 129-130, 157, 160-161
  governance_transactions_factory.py
  governance_transactions_outcome_parser.py
  resources.py
Project Total  

This report was generated by python-coverage-comment-action

mradian1
mradian1 previously approved these changes May 21, 2025
self._ensure_no_error(transaction_on_network.logs.events)
events = find_events_by_identifier(transaction_on_network, "proposal")
outcome: list[ProposeProposalOutcome] = []
outcome: list[NewProposalOutcome] = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable 👍

@popenta popenta merged commit 6b7af23 into feat/next May 22, 2025
7 checks passed
@popenta popenta deleted the governance-fix branch May 22, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants