Artifact rkyv#16
Merged
Merged
Conversation
| # It is not intended for manual editing. | ||
| version = 3 | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
Cargo.lock should probably be gitignored entirely
andrei-marinica
approved these changes
Feb 10, 2022
catalinnnn
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Rkyv serialization support for
wasmer_runtime_core::cache::Artifact, the structure produced by serializing an instance.Rkyvallows for much more efficient deserialization.By default, Wasmer starts with
Rkyvdisabled (seewasmer_singlepass_backend::USE_RKYV_SERIALIZATION). It can be turned on and off using the C API methodswasmer_instance_enable_rkyv()andwasmer_instance_disable_rkyv().The changes are mostly concerned with adding the proper
derivemacros to the relevantstructsandenums, and also with switching betweenRkyvserialization and the legacyserde.A special case is
wasmer_runtime_core::sys::ArchivableMemory, which is a custom wrapper for theMemoryof an instance (defined in the same crate). Normally,Memorycannot be archived, because it holds a reference to an actual memory page requested from the kernel usingmmap(). But theArchivableMemorywrapper provides an intermediate step, copying the contents of the memory pages into aCompactMemorystruct, which is easily serialized byRkyv.