add motor_pwm_rate to msp_config#238
add motor_pwm_rate to msp_config#238trollcop merged 1 commit intomultiwii:masterfrom luggi:motor_pwm
Conversation
There was a problem hiding this comment.
isn't this going to fail very badly without configurator support?
There was a problem hiding this comment.
i think it should be added to the configurator -> see irc
There was a problem hiding this comment.
sure but if we're going to change size let's add about 10 or so bytes of
dummy shit for later expansion.
not on irc now
On Jan 18, 2015 1:44 AM, "luggi" notifications@github.com wrote:
In src/serial.c
#238 (diff)
:@@ -858,6 +858,7 @@ static void evaluateCommand(void)
mcfg.board_align_yaw = read16(); // board_align_yaw
mcfg.currentscale = read16();
mcfg.currentoffset = read16();
mcfg.motor_pwm_rate = read16();i think it should be added to the configurator -> see irc
—
Reply to this email directly or view it on GitHub
https://github.com/multiwii/baseflight/pull/238/files#r23126446.
There was a problem hiding this comment.
i added support for those 2 extra bytes in my dev branch for now, i have an idea how i could deal with such "non-compatible" changes in the future (where configurator wouldn't need a change of code when such thing gets added, and it would gracefully relay the data back afterwards even when there is no GUI support for the extra bytes), but it would take a good day or two of coding to rewrite the whole MSP to deal with data in that manner and it would also break the backup/restore implementation, so i am not so sure about committing to this just yet :/
|
@luggi is this still relevant? |
|
test this please |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_289.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_291.html |
|
test this please |
add motor_pwm_rate to msp_config
No description provided.