Skip to content

add motor_pwm_rate to msp_config#238

Merged
trollcop merged 1 commit intomultiwii:masterfrom
luggi:motor_pwm
Mar 17, 2015
Merged

add motor_pwm_rate to msp_config#238
trollcop merged 1 commit intomultiwii:masterfrom
luggi:motor_pwm

Conversation

@luggi
Copy link
Copy Markdown
Contributor

@luggi luggi commented Jan 17, 2015

No description provided.

Comment thread src/serial.c Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this going to fail very badly without configurator support?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be added to the configurator -> see irc

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure but if we're going to change size let's add about 10 or so bytes of
dummy shit for later expansion.

not on irc now
On Jan 18, 2015 1:44 AM, "luggi" notifications@github.com wrote:

In src/serial.c
#238 (diff)
:

@@ -858,6 +858,7 @@ static void evaluateCommand(void)
mcfg.board_align_yaw = read16(); // board_align_yaw
mcfg.currentscale = read16();
mcfg.currentoffset = read16();

  •    mcfg.motor_pwm_rate = read16();
    

i think it should be added to the configurator -> see irc


Reply to this email directly or view it on GitHub
https://github.com/multiwii/baseflight/pull/238/files#r23126446.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added support for those 2 extra bytes in my dev branch for now, i have an idea how i could deal with such "non-compatible" changes in the future (where configurator wouldn't need a change of code when such thing gets added, and it would gracefully relay the data back afterwards even when there is no GUI support for the extra bytes), but it would take a good day or two of coding to rewrite the whole MSP to deal with data in that manner and it would also break the backup/restore implementation, so i am not so sure about committing to this just yet :/

@fiendie
Copy link
Copy Markdown
Member

fiendie commented Mar 13, 2015

@luggi is this still relevant?

@readerror67
Copy link
Copy Markdown
Contributor

test this please

@ghost
Copy link
Copy Markdown

ghost commented Mar 15, 2015

Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_289.html

@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2015

Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_291.html

@luggi
Copy link
Copy Markdown
Contributor Author

luggi commented Mar 16, 2015

test this please

trollcop added a commit that referenced this pull request Mar 17, 2015
add motor_pwm_rate to msp_config
@trollcop trollcop merged commit 7aa0936 into multiwii:master Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants