Conversation
ilateur
requested changes
Apr 14, 2026
JonathanMaes
requested changes
Apr 14, 2026
JonathanMaes
approved these changes
Apr 14, 2026
ilateur
reviewed
Apr 16, 2026
Collaborator
ilateur
left a comment
ilateur
left a comment
There was a problem hiding this comment.
It's a bit funny and sad that we now have nice functionality to save and load ovf files... but not npy files. Would it be nice to also have a save_npy() function? Or make it one save() function and decide the type based on the given string (or default if not given)? Or is this useless (just call np.save(field_quantity.eval())) or outside the scope of this pull request?
JonathanMaes
approved these changes
Apr 17, 2026
ilateur
approved these changes
Apr 17, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
save_ovfandload_ovfmethods toFieldQuantities. This allows users to save and loadFieldQuantitiesvia OVF files.The
save_ovfmethod usespyovfand provides it with all available metadata. However, some metadata appears to be ignored (e.g. simulation time) and some fields are hard-coded in pyovf (e.g. units).pyovfexpects arrays with shape(nz, ny, nx, ncomp), while mumax⁺ uses(ncomp, nz, ny, nx). The save function reorders the axis, while the load function reverses this. To notify users of this reordering, the save function has a warning in the docstring.