Add metrics to KafkaClient. #424
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to collect data about how long I'm waiting on Kafka; I want to answer questions like "how much latency is there for getting messages out of Kafka?". To this end, I've put together this PR, which adds an option to enable metrics collection in
KafkaClient.This uses scales, and would let me write stuff like this:
I've only added support for metrics in KafkaConsumer, but I can add other consumers if you agree with this design.