Add ISIN validation constraint#89
Merged
strider2038 merged 2 commits intomainfrom Apr 4, 2026
Merged
Conversation
Align format and Luhn checksum with Symfony Isin validator. Add English/Russian messages, constraint tests, and examples. Co-authored-by: Igor Lazarev <strider2038@yandex.ru>
- Add CHANGELOG.md with Unreleased (ISIN) and v0.19.0 history - Remove RELEASE_NOTES.md - Document changelog rules for agents in AGENTS.md - Extend constraint skill checklist for CHANGELOG updates Co-authored-by: Igor Lazarev <strider2038@yandex.ru>
strider2038
deleted the
cursor/-bc-f3bb1229-b862-4389-b59b-67a226f7ded1-f668
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds International Securities Identification Number (ISIN) validation aligned with Symfony's
Isinconstraint: length 12, pattern[A-Z]{2}[A-Z0-9]{9}[0-9](after uppercasing), and Luhn check on the expanded base-36 digit string.Changes
validate.ISINwithErrTooShort,ErrTooLong,ErrInvalidCharacters,ErrInvalidChecksumit.IsISIN,is.ISIN, messageInvalidISINandErrInvalidISINwith English/Russian translationsit,validate, andisRELEASE_NOTES.mdreplaced byCHANGELOG.md(Keep a Changelog); ISIN noted under[Unreleased]; agent instructions updated inAGENTS.mdand the constraint skill checklistTesting
go test -race ./...golangci-lint runCloses IGO-6 (Linear).