Skip to content

fix(editor): stabilize quote and callout list editing - #252

Merged
murongg merged 1 commit into
mainfrom
fix/quote-list-followup
Jun 12, 2026
Merged

fix(editor): stabilize quote and callout list editing#252
murongg merged 1 commit into
mainfrom
fix/quote-list-followup

Conversation

@murongg

@murongg murongg commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Align ordinary blockquote Enter behavior with callouts: non-empty lines continue inside the quote, while blank quote lines exit.
  • Stabilize list editing in blockquotes and callouts, including Enter, Tab, Shift+Tab, empty list deletion, and sibling indentation preservation.
  • Finalize live markdown and continue the Enter action in the same keystroke for quote/callout content.

Why

  • Follow-up feedback on [Bug]: GitHub 风格警告框的bug #224 reported ordinary blockquote list regressions and callout/quote Enter/list indentation behavior that differed from Typora-style expectations.

Validation

  • pnpm --filter @markra/app exec vitest run src/components/MarkdownPaper.test.tsx passed (344 tests)
  • pnpm --filter @markra/app exec vitest run src/components/MarkdownPaper.test.tsx -t "quote formatting|quote list|callout body|callout list|callouts on Enter|callout.*Enter|live markdown inside|typed quote content|typed callout content|Shift\\+Tab|Tab like ordinary|list continuation|without reducing|nests only the current" passed (59 tests)
  • pnpm --filter @markra/editor test passed (3 tests)
  • pnpm -r --if-present test passed
  • pnpm -r --if-present build passed
  • git diff --check HEAD passed

Risk

  • The changed surface is editor keyboard handling inside lists, blockquotes, and callouts; the main residual risk is platform-specific desktop key/caret behavior not captured by jsdom.

Related Issues

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 12, 2026 2:31am

@murongg
murongg merged commit 30e269a into main Jun 12, 2026
4 checks passed
@murongg
murongg deleted the fix/quote-list-followup branch June 12, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant