Skip to content

fix(app): reset settings scroll on category changes - #317

Merged
murongg merged 1 commit into
mainfrom
fix/issue-313-settings-scroll
Jun 17, 2026
Merged

fix(app): reset settings scroll on category changes#317
murongg merged 1 commit into
mainfrom
fix/issue-313-settings-scroll

Conversation

@murongg

@murongg murongg commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reset the shared settings content scroll container whenever the active settings category changes.
  • Add regression coverage for switching from a scrolled AI settings panel into Providers.

Why

Validation

  • pnpm --filter @markra/app test -- SettingsShell.test.tsx passed: 84 files, 1207 tests.
  • pnpm --filter @markra/app build passed.

Risk

  • Low: only resets scroll position on settings category changes.

Closes #313

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 17, 2026 1:06pm

@murongg
murongg marked this pull request as ready for review June 17, 2026 13:26
@murongg
murongg merged commit da2bbcb into main Jun 17, 2026
4 checks passed
@murongg
murongg deleted the fix/issue-313-settings-scroll branch June 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 进入设置后,如果按从上到下顺序切到 供应商 tab,高概率触发显示bug

1 participant