Skip to content

feat(app): split appearance mode and theme palettes - #319

Merged
murongg merged 1 commit into
mainfrom
feature/issue-314-theme-preferences
Jun 17, 2026
Merged

feat(app): split appearance mode and theme palettes#319
murongg merged 1 commit into
mainfrom
feature/issue-314-theme-preferences

Conversation

@murongg

@murongg murongg commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Separate appearance mode from saved light and dark editor palettes.
  • Preserve legacy theme and custom CSS values by migrating them into split preferences.
  • Add isolated light/dark custom CSS editors and complete locale strings for the new labels.

Why

  • The titlebar mode toggle should switch appearance without overwriting the user's chosen light or dark palette.
  • Separate custom CSS fields avoid one custom theme stylesheet leaking across both appearances.

Validation

  • pnpm --filter @markra/shared build passed
  • pnpm --filter @markra/app test passed: 84 files, 1212 tests
  • pnpm --filter @markra/app build passed
  • Theme i18n key scan passed for all locale files

Risk

  • Theme settings storage now reads legacy keys as fallback and writes the new split keys going forward.
  • App tests still print existing jsdom Window.scrollBy() not implemented warnings, but the test command exits successfully.

Closes #314

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 17, 2026 2:09pm

@murongg
murongg marked this pull request as ready for review June 17, 2026 14:14
@murongg
murongg merged commit cc078f8 into main Jun 17, 2026
4 checks passed
@murongg
murongg deleted the feature/issue-314-theme-preferences branch June 17, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 主窗口右上角的☀️/🌙按钮将会破坏用户选择的主题

1 participant