Skip to content

feat(editor): add system font selection - #328

Merged
murongg merged 1 commit into
mainfrom
feature/issue-281-editor-fonts
Jun 18, 2026
Merged

feat(editor): add system font selection#328
murongg merged 1 commit into
mainfrom
feature/issue-281-editor-fonts

Conversation

@murongg

@murongg murongg commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add an editor font family preference backed by native system font enumeration.
  • Add a searchable font dropdown with localized labels, option previews, and selected-value preview.
  • Apply the selected font to visual/source editor surfaces and migrate older localized saved values to CSS-usable family names.

Why

  • Lets users customize the editor font while keeping WebView-compatible font application.

Validation

  • pnpm --filter @markra/app test passed: 84 files, 1228 tests.
  • pnpm --filter @markra/app typecheck:test passed.
  • pnpm --filter @markra/app build passed.
  • pnpm --filter @markra/desktop test passed: 10 files, 98 tests.
  • pnpm --filter @markra/desktop typecheck:test passed.
  • pnpm --filter @markra/desktop build passed, including vendor chunk verification.
  • cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml passed: 159 tests, with existing menu dead_code warnings.

Risk

  • Font family labels and CSS family names can differ by platform. The implementation keeps separate display labels and CSS family values, with fallback behavior when platform-native labels are unavailable.

Closes #281

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 18, 2026 5:28am

@murongg
murongg marked this pull request as ready for review June 18, 2026 05:33
@murongg
murongg merged commit acad7ea into main Jun 18, 2026
4 checks passed
@murongg
murongg deleted the feature/issue-281-editor-fonts branch June 18, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 增加字体的设置选项

1 participant