Skip to content

fix(desktop): restore Windows titlebar double-click toggle - #342

Merged
murongg merged 1 commit into
mainfrom
fix/windows-titlebar-restore
Jun 19, 2026
Merged

fix(desktop): restore Windows titlebar double-click toggle#342
murongg merged 1 commit into
mainfrom
fix/windows-titlebar-restore

Conversation

@murongg

@murongg murongg commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route Windows self-drawn titlebar double-click mouse downs through the existing window maximize toggle handler.
  • Avoid intercepting interactive titlebar targets such as buttons, tabs, menu items, and titlebar action controls.
  • Add coverage for the Windows app chrome and document titlebar double-click paths.

Why

  • On Windows, double-clicking the self-drawn titlebar could maximize the app, but a second double-click did not reliably restore it.

Validation

  • pnpm --filter @markra/app test -- NativeTitleBar.test.tsx passed: 38 tests.
  • pnpm --filter @markra/app typecheck:test passed.

Risk

  • Low. The handler is only attached inside the Windows titlebar branch and only handles native-window-chrome left-button double-click mouse downs outside interactive controls.

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 19, 2026 3:01am

@murongg
murongg merged commit 27e6433 into main Jun 19, 2026
4 checks passed
@murongg
murongg deleted the fix/windows-titlebar-restore branch June 19, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant