Skip to content

fix(app): polish Windows titlebar borders - #345

Merged
murongg merged 1 commit into
mainfrom
fix/windows-titlebar-border
Jun 19, 2026
Merged

fix(app): polish Windows titlebar borders#345
murongg merged 1 commit into
mainfrom
fix/windows-titlebar-border

Conversation

@murongg

@murongg murongg commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move Windows titlebar chrome, menu construction, and double-click maximize handling into WindowsNativeTitleBar
  • Draw the expanded sidebar border pieces inside the moving Windows titlebar to avoid double-border artifacts during sidebar animation
  • Keep shared titlebar actions in NativeTitleBar while isolating Windows-only rendering and interaction details

Validation

  • pnpm --filter @markra/app test -- NativeTitleBar.test.tsx passed (38 tests)
  • pnpm --filter @markra/app typecheck:test passed
  • git diff --check HEAD passed

Risk

  • Low; the rendering change is isolated to Windows titlebar chrome, with existing titlebar tests covering Windows and non-Windows paths

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 19, 2026 3:52am

@murongg
murongg force-pushed the fix/windows-titlebar-border branch from 6491839 to 803a8e5 Compare June 19, 2026 03:51
@murongg
murongg merged commit bfbbd09 into main Jun 19, 2026
4 checks passed
@murongg
murongg deleted the fix/windows-titlebar-border branch June 19, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant