chore: clean warning output - #347
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
murongg
marked this pull request as ready for review
June 19, 2026 04:13
murongg
force-pushed
the
chore/clean-warning-output
branch
from
June 19, 2026 04:20
01ee47f to
63af5b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.scrollBytest-environment mock to quiet jsdom output in@markra/apptests.#[cfg(windows)]so non-Windows builds do not warn about unused functions.Why
Validation
pnpm --filter @markra/app testpassed: 88 test files, 1272 testspnpm --filter @markra/app typecheck:testpassedpnpm testpassed across the workspacecargo checkpassed inapps/desktop/src-taurigit diff --checkpassed