Skip to content

fix(app): restore persisted settings state - #348

Merged
murongg merged 1 commit into
mainfrom
fix/restore-sidebar-state
Jun 19, 2026
Merged

fix(app): restore persisted settings state#348
murongg merged 1 commit into
mainfrom
fix/restore-sidebar-state

Conversation

@murongg

@murongg murongg commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restore the persisted workspace sidebar expanded/collapsed state during file tree startup
  • prevent late initial settings loads from overwriting live settings updates
  • add regression coverage for sidebar state restore and late settings-load races

Why

  • Windows could show the sidebar in the default state even when fileTreeOpen had been saved.
  • Settings hooks could briefly accept a live user/cross-window update, then be overwritten by an older async startup read.

Validation

  • pnpm --filter @markra/app test -- useEditorPreferences.test.tsx useAiSettings.test.tsx useMarkdownFileTree.test.tsx App.test.tsx passed: 185 tests
  • pnpm --filter @markra/app test -- workspace-state.test.ts settings-events.test.ts passed: 19 tests
  • pnpm --filter @markra/app typecheck:test passed

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 19, 2026 4:15am

@murongg
murongg merged commit 13d5cbb into main Jun 19, 2026
4 checks passed
@murongg
murongg deleted the fix/restore-sidebar-state branch June 19, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant