Skip to content

Fix key signatures regarding concert pitch when cloning staff#16563

Merged
RomanPudashkin merged 5 commits intomusescore:masterfrom
cbjeukendrup:parts_concert_pitch
Mar 6, 2023
Merged

Fix key signatures regarding concert pitch when cloning staff#16563
RomanPudashkin merged 5 commits intomusescore:masterfrom
cbjeukendrup:parts_concert_pitch

Conversation

@cbjeukendrup
Copy link
Copy Markdown
Collaborator

when either the full score is in concert pitch and the part not, or the part is in concert pitch and the score not.

Resolves: #16554

@cbjeukendrup
Copy link
Copy Markdown
Collaborator Author

The third commit is an attempt to fix an assertion failure that happened sometimes but I still haven't found a way to reproduce it reliably. It must be some permutation of toggling concert pitch in the full score and in the part score, adding instruments and saving/closing/reopening, and adding key signatures.

The fourth commit fixes an additional bug that still occurred after the second commit:

  1. Create score with transposing instrument and concert C major key sig
  2. Turn on concert pitch
  3. Save close reopen
  4. Turn off concert pitch
  5. Create new empty part
  6. Make the instrument visible in that part
    -> the instrument has the wrong key sig in the part

@mike-spa Since you have worked before on issues that turned out to be related to deleting C major key signatures at the beginning of a score, could you please check if this PR looks good to you?

Copy link
Copy Markdown
Contributor

@mike-spa mike-spa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbjeukendrup as far as I can see, this looks perfectly coherent with all the other similar fixes I've done (removing a keySig from the score just because it happens to be C is a very wrong idea IMO, so I'm very glad to see it gone).

@RomanPudashkin
Copy link
Copy Markdown
Contributor

@cbjeukendrup please pay attention to the failed tests

@cbjeukendrup cbjeukendrup force-pushed the parts_concert_pitch branch from 45b3f7d to 76b62f2 Compare March 1, 2023 23:12
@cbjeukendrup cbjeukendrup force-pushed the parts_concert_pitch branch from 76b62f2 to 56486e5 Compare March 4, 2023 14:23
@cbjeukendrup
Copy link
Copy Markdown
Collaborator Author

@RomanPudashkin Done!

@RomanPudashkin RomanPudashkin merged commit f983aa0 into musescore:master Mar 6, 2023
@cbjeukendrup cbjeukendrup deleted the parts_concert_pitch branch March 6, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Parts created while score in concert pitch have incorrect key signatures

3 participants