Fix key signatures regarding concert pitch when cloning staff#16563
Fix key signatures regarding concert pitch when cloning staff#16563RomanPudashkin merged 5 commits intomusescore:masterfrom
Conversation
|
The third commit is an attempt to fix an assertion failure that happened sometimes but I still haven't found a way to reproduce it reliably. It must be some permutation of toggling concert pitch in the full score and in the part score, adding instruments and saving/closing/reopening, and adding key signatures. The fourth commit fixes an additional bug that still occurred after the second commit:
@mike-spa Since you have worked before on issues that turned out to be related to deleting C major key signatures at the beginning of a score, could you please check if this PR looks good to you? |
mike-spa
left a comment
There was a problem hiding this comment.
@cbjeukendrup as far as I can see, this looks perfectly coherent with all the other similar fixes I've done (removing a keySig from the score just because it happens to be C is a very wrong idea IMO, so I'm very glad to see it gone).
|
@cbjeukendrup please pay attention to the failed tests |
45b3f7d to
76b62f2
Compare
when either the full score is in concert pitch and the part not, or the part is in concert pitch and the score not.
76b62f2 to
56486e5
Compare
|
@RomanPudashkin Done! |
when either the full score is in concert pitch and the part not, or the part is in concert pitch and the score not.
Resolves: #16554