Skip to content

gp-import: adding tied note for skipped notes in gp5#26246

Merged
alexpavlov96 merged 1 commit intomasterfrom
XTC-1191_gp5_ties
Jan 27, 2025
Merged

gp-import: adding tied note for skipped notes in gp5#26246
alexpavlov96 merged 1 commit intomasterfrom
XTC-1191_gp5_ties

Conversation

@alexpavlov96
Copy link
Contributor

@alexpavlov96 alexpavlov96 commented Jan 26, 2025

skipped_tied_notes.gp5.zip

some versions of guitar pro 5 allowed to make a tie skipping a note between 2 tied notes:
Screenshot 2025-01-26 193452

PR adds extra tied notes:
Screenshot 2025-01-26 at 19 38 27

@cbjeukendrup
Copy link
Collaborator

FWIW, I believe MS Studio also allows exactly the same notation as GP: to create such situation in the GUI, enter those four notes, then select the first one and click the Tie button, and it will automatically tie to the next note of the same pitch, even if there are other notes in between. In practice, this means you can validly call tie->setEndNote with any note that's anywhere after the start note and has the same pitch.

@alexpavlov96
Copy link
Contributor Author

FWIW, I believe MS Studio also allows exactly the same notation as GP: to create such situation in the GUI, enter those four notes, then select the first one and click the Tie button, and it will automatically tie to the next note of the same pitch, even if there are other notes in between. In practice, this means you can validly call tie->setEndNote with any note that's anywhere after the start note and has the same pitch.

Thank you very much!
I will leave this to @abariska, I can just add that it's not possible to do so in newer guitar pro versions, and even guitar pro itself opens old files with extra created notes.

@abariska
Copy link
Contributor

FWIW, I believe MS Studio also allows exactly the same notation as GP: to create such situation in the GUI, enter those four notes, then select the first one and click the Tie button, and it will automatically tie to the next note of the same pitch, even if there are other notes in between. In practice, this means you can validly call tie->setEndNote with any note that's anywhere after the start note and has the same pitch.

Thank you very much! I will leave this to @abariska, I can just add that it's not possible to do so in newer guitar pro versions, and even guitar pro itself opens old files with extra created notes.

Yes, there's no reason to implement this logic only for old GP versions. Current fix is enough. Thanks

@alexpavlov96 alexpavlov96 merged commit c424380 into master Jan 27, 2025
11 checks passed
@alexpavlov96 alexpavlov96 deleted the XTC-1191_gp5_ties branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants