[MusicXML] export all articulations #27314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
force-pushed
the
xml/articulations
branch
2 times, most recently
from
7161b96 to
7d63942
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 23, 2025
export all remaining articulations as other-articulation Backport of musescore#27314
ghost
requested a review
from 
ghost
added
the
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 29, 2025
export all remaining articulations as other-articulation Backport of musescore#27314
miiizen
reviewed
Apr 1, 2025
src/importexport/musicxml/internal/musicxml/export/exportmusicxml.cpp
Outdated
Show resolved
Hide resolved
rettinghaus
force-pushed
the
xml/articulations
branch
from
e942162 to
dbfd087
Compare
rettinghaus
force-pushed
the
xml/articulations
branch
from
dbfd087 to
2a4133d
Compare
rettinghaus
force-pushed
the
xml/articulations
branch
from
2a4133d to
5e492ec
Compare
| AsciiStringView noteheadName = SymNames::nameForSymId(sid); | ||
| otherArtic += String(u" smufl=\"%1\"").arg(String::fromAscii(noteheadName.ascii())); | ||
| m_xml.tagRaw(otherArtic); | ||
| m_xml.endElement(); |
Member
There was a problem hiding this comment.
I'm not super familiar with the MusicXML export code, but when comparing this to line 3536, I wonder why there is an endElement here and not there.
Contributor
Author
There was a problem hiding this comment.
Good question. I removed it.
Contributor
Author
There was a problem hiding this comment.
@cbjeukendrup turns out, the endElement is needed there, although I should have used articulations.etag. Working on a fix right now.
Member
There was a problem hiding this comment.
Ah, good. Perhaps we should also have a unit test here.
rettinghaus
force-pushed
the
xml/articulations
branch
from
5e492ec to
c8f10bd
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 17, 2025
export all remaining articulations as other-articulation Backport of musescore#27314
cbjeukendrup
approved these changes
Aug 17, 2025
github-project-automation
bot
moved this from In Progress
to Needs porting
in MuseScore Studio 4.6
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 17, 2025
export all remaining articulations as other-articulation Backport of musescore#27314
RomanPudashkin
pushed a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Aug 27, 2025
[MusicXML] export all articulations
Merged
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 29, 2025
Backport of musescore#29447, fixing issues introduced with the backport of musescore#27314
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 29, 2025
Backport of musescore#29447, fixing issues introduced with the backport of musescore#27314
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 29, 2025
Backport of musescore#29447, fixing issues introduced with the backport of musescore#27314
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 29, 2025
Backport of musescore#29447, fixing issues introduced with the backport of musescore#27314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure all articulations previously unhandled are exported as
other-articulation.