Skip to content

Conversation

@joaotomas007
Copy link
Contributor

Resolves: #26074

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Member

Hi, thanks for the PR! Two things:

  • instead of merging the master branch into your branch, we prefer that you rebase your branch on top of the master branch. To do so, run git pull --rebase upstream master; git push -f to rebase on master and then push your updated branch.
  • you're modifying third-party code in this PR, namely KDDockWidgets code, rather than MuseScore's own code. In general, we try to avoid that, but in this case it's clearly unavoidable; and with KDDockWidgets we've kind of given up trying not to patch it, because we simply had to. So, no problem with this PR, but you may want to consider checking whether the same problem applies to the latest version of KDDockWidgets at https://github.com/kdab/KDDockWidgets, and submitting a fix there as well, so that even more people than just us can benefit from it :)

The issue stemmed from the custom window resizing handler,
which did not account for whether the window being resized
was the one upfront. As a result, it was possible to
resize a window even while interacting with another
window in front of it. This has been fixed by updating
the eventFilter function to check the window directly
under the cursor, ensuring that only the intended window
is pressed.
@DmitryArefiev
Copy link
Contributor

Tested #26074 on Win10, Mac13.7.2, LinuxUbuntu24.04.2 LTS - FIXED

@cbjeukendrup cbjeukendrup merged commit c0e962a into musescore:master May 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A scroll drag in the Style dialog should not affect the dimension of the Mixer (Mixer in undocked state)

3 participants