Skip to content

Conversation

@HemantAntony
Copy link
Contributor

@HemantAntony HemantAntony commented Apr 15, 2025

Resolves: #23090

Which font the dynamic should be displayed in is decided in the Dynamic's setXmlText method which is overridden. Additionally, fragments are also assigned a type to denote what type of text it contains. It currently contains a plain dynamic one which is for dynamics in expression text style along with a default one for all the other text.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@shoogle

@HemantAntony HemantAntony changed the title Fix #23090: Added style option to use expression font for dynamics Fix #23090: Added style option to display dynamics in expression text style Apr 15, 2025
Copy link
Contributor

@shoogle shoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaviour is as requested, thanks!

The code looks much less invasive this time, but I noticed an issue with how you are storing dynamics in MSCX files.

BTW, we're still thinking about exactly where to include this in the UI. We might not want to put it in the Style dialog after all, but maybe a new dialog or panel specifically for accessibility style settings. It wouldn't change how the feature works internally though.

…namics

Which font the dynamic should be displayed in is decided in TextBase::createBlocks method. Additionally, fragments are also assigned a type to denote what type of text it contains. It currently contains a plain dynamic one which is for dynamics in expression text style along with a default one for all the other text.
@HemantAntony HemantAntony force-pushed the 23090-display_dynamics_in_expression_font branch from b2a4439 to 8ac8af9 Compare April 19, 2025 08:56
@HemantAntony HemantAntony requested a review from shoogle April 19, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add style option to use text font for dynamics

2 participants