Fix tie toggle in parts #27720
Merged
Fix tie toggle in parts #27720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
approved these changes
Apr 16, 2025
Contributor
|
Tested #27718 on Win10, Mac13.7.2 - FIXED |
4 tasks
mike-spa
reviewed
Apr 17, 2025
| && firstMasterMeasureBase->isMeasure() ? toMeasure(firstMasterMeasureBase) : nullptr; | ||
| const MeasureBase* secondMasterMeasureBase = master->measure(secondMeasure->index()); | ||
| const Measure* secondMasterMeasure = secondMasterMeasureBase | ||
| && secondMasterMeasureBase->isMeasure() ? toMeasure(secondMasterMeasureBase) : nullptr; |
Contributor
There was a problem hiding this comment.
Wouldn't this be more immediate by doing e.g. master->tick2measure(firstMeasure->tick())? It should also be much faster after your work on tick indexing
Contributor
There was a problem hiding this comment.
Otherwise looks good, feel free to merge after this small change 👍
Contributor
Author
There was a problem hiding this comment.
Yes, definitely! I'd actually prefer to be overly cautious and make these changes in 4.6 as tick indexing won't be in the patch. This method of accessing measures has been fine for findFollowing/PreviousRepeatMeasures and I'd hate to break something now
mike-spa
approved these changes
Apr 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #27718
There is only one repeat list for all parts, so we need to find the master measure when comparing to repeat list measures.