Fix #24957 plus new TPC transposing method#30139
Merged
Merged
Conversation
cbjeukendrup
approved these changes
Sep 26, 2025
Collaborator
|
@XiaoMigros Besides the linked issue and perhaps some pitch editing and transposing operations, do you have any other recommendations for things that should be tested? |
Contributor
Author
|
The only logic changes have been made to transposition, ambitus pitch calculation, and general pitch calculation. Please test all sorts of pitch input options (keyboard, clicking, dragging, keyboard editing) as well as transposition through instruments, the transpose dialog and of ornaments. |
e898f74 to
8ea2cba
Compare
And use int for the pitch ranges in instrument templates.
b54f5b1 to
f87d6f7
Compare
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved #24957 FIXED |
cbjeukendrup
approved these changes
Oct 8, 2025
Collaborator
cbjeukendrup
left a comment
There was a problem hiding this comment.
Really nice cleanups! Thanks!
Contributor
Author
|
Thank you! An apt 100th merged PR :) |
Collaborator
|
Ooh congratulations! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #24957 - Ottavas now included in ambitus calculations