Fix stray parentheses for extensions actions that have no name#32077
Merged
cbjeukendrup merged 2 commits intomasterfrom Feb 10, 2026
Merged
Fix stray parentheses for extensions actions that have no name#32077cbjeukendrup merged 2 commits intomasterfrom
cbjeukendrup merged 2 commits intomasterfrom
Conversation
XiaoMigros
reviewed
Feb 7, 2026
An extension can have one or more actions, and those actions may or not have a title.
to avoid unexpected fallback to the UiAction name (which is “Run plugin …”, which is unnecessarily long)
cbjeukendrup
force-pushed
the
colornotes-stray-parentheses
branch
from
8f6cbfe to
d220763
Compare
XiaoMigros
approved these changes
Feb 7, 2026
Contributor
XiaoMigros
left a comment
XiaoMigros
left a comment
There was a problem hiding this comment.
Looks good! Supercedes my draft too. Translation notes also helpful.
Contributor
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extension can have one or more actions, and those actions may or not have a title.
Resolves: #32074