Fix #32152: Fall back to lastElementHit in playFromSelection [4.7.0]#32232
Merged
mathesoncalum merged 2 commits intomusescore:4.7from Mar 27, 2026
Merged
Fix #32152: Fall back to lastElementHit in playFromSelection [4.7.0]#32232mathesoncalum merged 2 commits intomusescore:4.7from
mathesoncalum merged 2 commits intomusescore:4.7from
Conversation
RomanPudashkin
approved these changes
Feb 17, 2026
Contributor
|
There is a crash if I open parts and use shift+space to play 2026-02-17.17-20-05.mp4 |
Contributor
|
Diagnostic files: Basic test score if it helps |
mathesoncalum
force-pushed
the
32152-play_no_selection
branch
from
4dc2a7f to
8eb08a0
Compare
Contributor
Author
partscrash.movCan't quite repro that crash @zacjansheski (in this video I'm spamming shift+space immediately after opening all parts). I've just rebased the PR - I'm wondering if this is present for you on both macOS and Windows? |
Contributor
|
Sorry I can't show my key presses on Linux, but I can reproduce. See if you can reproduce when you switch parts Screencast.from.2026-02-18.10-56-31.mp4 |
Contributor
|
@zacjansheski fixed, please retest |
This comment was marked as outdated.
This comment was marked as outdated.
mathesoncalum
changed the title
mathesoncalum
force-pushed
the
32152-play_no_selection
branch
from
79ac1fd to
c612eba
Compare
Contributor
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32152