Draft
Conversation
Eism
reviewed
Feb 19, 2026
| Q_INVOKABLE void raise(); | ||
| Q_INVOKABLE void accept(); | ||
| Q_INVOKABLE void reject(int code = -1); | ||
| Q_INVOKABLE void repositionWindowIfNeed() override; |
Contributor
There was a problem hiding this comment.
I don't think you'll be using this in qml, so let's remove Q_INVOKABLE. (For popups, it's more of a hack)
Contributor
Author
|
I need to adjust that PR to only center dialog "on spawn" not "on resize" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: vertically center dialogs by adding repositionWindowIfNeed method to DialogView and trigger during size update