Skip to content

vertically center dialogs#32256

Draft
luapmartin wants to merge 1 commit intomusescore:masterfrom
luapmartin:luapmartin/vertical-center-dialogs
Draft

vertically center dialogs#32256
luapmartin wants to merge 1 commit intomusescore:masterfrom
luapmartin:luapmartin/vertical-center-dialogs

Conversation

@luapmartin
Copy link
Copy Markdown
Contributor

Resolves: vertically center dialogs by adding repositionWindowIfNeed method to DialogView and trigger during size update

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Q_INVOKABLE void raise();
Q_INVOKABLE void accept();
Q_INVOKABLE void reject(int code = -1);
Q_INVOKABLE void repositionWindowIfNeed() override;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you'll be using this in qml, so let's remove Q_INVOKABLE. (For popups, it's more of a hack)

@Eism Eism self-requested a review February 19, 2026 08:30
@luapmartin luapmartin marked this pull request as draft February 19, 2026 08:37
@luapmartin
Copy link
Copy Markdown
Contributor Author

I need to adjust that PR to only center dialog "on spawn" not "on resize"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants