Skip to content

[4.7] Video export. Step 3. Added video encoders for ffmpeg v4-v8#32647

Merged
Eism merged 26 commits intomusescore:4.7from
Eism:video_export_step3_4.7
Mar 17, 2026
Merged

[4.7] Video export. Step 3. Added video encoders for ffmpeg v4-v8#32647
Eism merged 26 commits intomusescore:4.7from
Eism:video_export_step3_4.7

Conversation

@Eism
Copy link
Copy Markdown
Contributor

@Eism Eism commented Mar 16, 2026

Resolves: #32570

  • Stabilized the solution for macOS and Windows, and maybe Linux but I didn't check yet
  • Moved settings to new Video page in Preferences, removed Update page and moved AutomaticUpdateSection to General page

@Eism Eism force-pushed the video_export_step3_4.7 branch from 230b739 to 3311035 Compare March 16, 2026 14:35
@Eism Eism force-pushed the video_export_step3_4.7 branch from 3311035 to fed76b1 Compare March 16, 2026 14:37
@Eism Eism marked this pull request as draft March 16, 2026 15:08
@Eism Eism force-pushed the video_export_step3_4.7 branch from f55c8aa to 0580d96 Compare March 17, 2026 09:27
@Eism Eism force-pushed the video_export_step3_4.7 branch from 0580d96 to eca6469 Compare March 17, 2026 10:09
@Eism Eism mentioned this pull request Mar 17, 2026
4 tasks
@Eism Eism marked this pull request as ready for review March 17, 2026 11:28
@Eism Eism requested review from igorkorsukov March 17, 2026 11:40
@Eism Eism moved this to In Progress in MuseScore Studio 4.7 Mar 17, 2026
Comment thread src/framework/media/internal/ffmpeg/v4/videoencoder.cpp Outdated
int64_t (*av_rescale_q)(int64_t a, AVRational bq, AVRational cq) = nullptr;

// libavutil (imgutils)
int (*av_image_fill_arrays)(uint8_t* dst_data[4], int dst_linesize[4], const uint8_t* src, AVPixelFormat pix_fmt, int width, int height,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for peace of mind, has this interface been cleared of unused (old) features? The others aren't that important... but this one is important because it will be copied in the future to support new versions.

@Eism Eism force-pushed the video_export_step3_4.7 branch from 3a20f1b to 5bf13d1 Compare March 17, 2026 13:22
@Eism Eism force-pushed the video_export_step3_4.7 branch from 5bf13d1 to 5952838 Compare March 17, 2026 14:07
@Eism Eism merged commit 9396f6b into musescore:4.7 Mar 17, 2026
12 checks passed
@Eism Eism deleted the video_export_step3_4.7 branch March 17, 2026 15:06
@github-project-automation github-project-automation Bot moved this from In Progress to Needs porting in MuseScore Studio 4.7 Mar 17, 2026
@Jojo-Schmitz
Copy link
Copy Markdown
Contributor

This added a whole bunch of compiler warnings, see #32662
Need to be aware when porting to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants