Fix element stacking during partial layout#32755
Conversation
|
Please keep PRs as draft until all checks have passed.
Also see the wiki page: Fix the CI checks. |
9300794 to
562c425
Compare
Thanks for reminding. |
mike-spa
left a comment
There was a problem hiding this comment.
@CubikingChill I see no problem with your code but I can't understand the issue that you are trying to solve as it's impossible to understand it from your description. Can you please attach screenshots to your issue, or even better a video capture? Thank you!
|
Sure. Screen recording on the way. |
2026-03-27.15-15-06.-.Trim.mp4 |
Elements (text, dynamics) were stacking after edits because autoplace collision detection used stale offset state. Clear autoplace state (offsetChanged, changedPos) during layout reset to force fresh collision detection without resetting positions.
562c425 to
1073c8e
Compare
|
I cannot see that the linked issue has been fixed in this PR. Here in a fresh master build: Screencast.from.2026-03-30.12-37-36.webm |
2026-03-30.12-51-45.mp4Interesting. The PR build is correct tho. |
|
The bug only presents in continuous view. In the recording above you are in page view. Screencast.from.2026-03-30.14-01-09.webm |
|
You are right. Sorry for my careless observation. I will work on that again. |
|
@CubikingChill no, you will not. We have noticed that in all of your PRs, the requirement that It is one thing to use AI to speed up the work. It is a different thing to blindly send us AI code that you haven't even compiled. It's disrespectful to us, as we all need to waste our time checking and testing and understanding dozens of low quality contributions that you haven't checked and tested and understood yourself. And it's disrespectful to all other community members who've contributed their own genuine work and time and skills over the years. From now on, I will close any PR where
|
|
Hello. I do admit that I didn't setup the environment on my PC. But for most PRs I did test at least the Linux x86 from the workflow. If testing the workflow build counts as "The code compiles". I am happy to do so in future. And I am also very willing to apologise for any carelessness when I test my build. If you need extra guarantee, I don't mind submitting a short video showing that the build works and makes a difference Last but not least, I admit that some of the PRs I created are of little effort. I promise that from now on I will put more efforts before marking PRs as read for review. |
No, it doesn't. Automated builds are meant to be used as an integration check and provide a way for non-developers to test the changes, they are not developer tools. If you want to contribute code, you set up your environment, build the software, make your changes, see if they work, and then you contribute. Thanks. |
Noted. |
Revert "Merge pull request #32755 from CubikingChill/fix-element-stac…
Elements (text, dynamics) were stacking on top of each other after edits, only returning to correct positions after save/reload. This occurred because partial layout reset only affected the edited measure range while skyline collision detection processed entire systems, creating mixed stale/fresh data.
Changes:
Fixes the mismatch between partial reset scope and full system processing.
Resolves: #32756