Rename to MuseScore Studio#33294
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (129)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (118)
📝 WalkthroughWalkthroughThis PR consolidates MuseScore's app naming infrastructure by removing legacy compatibility variables and updating build configuration across CMake, packaging, and platform-specific metadata to use machine-readable and human-readable app name variants consistently. Additionally, it applies "MuseScore Studio" branding throughout documentation and source file headers, and updates the muse submodule dependency. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
37069f6 to
6c4ac16
Compare
6c4ac16 to
c636d9c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@muse`:
- Line 1: The submodule reference for "muse" points to an invalid/unreachable
commit hash e59f6b12b842fd2383a594e80d7953fb5b20bd86; update the submodule
pointer to a valid commit or push the missing commit. Verify the correct commit
hash in the muse repository, then run git submodule set-branch/gitlink or update
the .gitmodules/gitlink entry (the submodule pointer) to the verified hash and
commit/push that change; alternatively push the missing commit to the remote so
e59f6b12b842fd2383a594e80d7953fb5b20bd86 becomes reachable. Ensure the updated
submodule state is committed in the parent repo so CI and other devs can fetch
it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 167672a1-9503-49c0-b15d-0ff6f1f771c4
📒 Files selected for processing (128)
README.mdSetupConfigure.cmakebuildscripts/packaging/Linux+BSD/SetupAppImagePackaging.cmakebuildscripts/packaging/Windows/PortableApps/appinfo.ini.inbuildscripts/packaging/Windows/SetupWindowsPackaging.cmakemuseshare/plugins/note_names/notenames.qmlsrc/app/CMakeLists.txtsrc/engraving/api/tests/CMakeLists.txtsrc/engraving/qml/MuseScore/Engraving/devtools/EngravingStyleDialog.qmlsrc/engraving/qml/MuseScore/Engraving/devtools/EngravingStylePanel.qmlsrc/engraving/qml/MuseScore/Engraving/devtools/EngravingUndoStackDialog.qmlsrc/engraving/qml/MuseScore/Engraving/devtools/EngravingUndoStackPanel.qmlsrc/engraving/qml/MuseScore/Engraving/devtools/engravingstylemodel.hsrc/engraving/qml/MuseScore/Engraving/devtools/engravingundostackmodel.cppsrc/engraving/qml/MuseScore/Engraving/devtools/engravingundostackmodel.hsrc/engraving/rendering/score/accidentalslayout.cppsrc/engraving/rendering/score/accidentalslayout.hsrc/engraving/tests/automation/automation_tests.cppsrc/engraving/tests/bsptree_tests.cppsrc/importexport/midi/tests/utils/smfyamlserializer.cppsrc/importexport/midi/tests/utils/smfyamlserializer.hsrc/macos_integration/CMakeLists.txtsrc/musesounds/CMakeLists.txtsrc/musesounds/imusesamplercheckupdatescenario.hsrc/musesounds/imusesamplercheckupdateservice.hsrc/musesounds/imusesoundscheckupdatescenario.hsrc/musesounds/imusesoundscheckupdateservice.hsrc/musesounds/imusesoundsconfiguration.hsrc/musesounds/imusesoundsrepository.hsrc/musesounds/internal/musesamplercheckupdatescenario.cppsrc/musesounds/internal/musesamplercheckupdatescenario.hsrc/musesounds/internal/musesamplercheckupdateservice.cppsrc/musesounds/internal/musesamplercheckupdateservice.hsrc/musesounds/internal/musesoundscheckupdatescenario.cppsrc/musesounds/internal/musesoundscheckupdatescenario.hsrc/musesounds/internal/musesoundscheckupdateservice.cppsrc/musesounds/internal/musesoundscheckupdateservice.hsrc/musesounds/internal/musesoundsconfiguration.cppsrc/musesounds/internal/musesoundsconfiguration.hsrc/musesounds/internal/musesoundsrepository.cppsrc/musesounds/internal/musesoundsrepository.hsrc/musesounds/musesoundserrors.hsrc/musesounds/musesoundstypes.hsrc/musesounds/qml/MuseScore/MuseSounds/MuseSoundsReleaseInfoDialog.qmlsrc/musesounds/qml/MuseScore/MuseSounds/internal/MuseSoundsReleaseInfoBottomPanel.qmlsrc/musesounds/qml/MuseScore/MuseSounds/internal/SoundCatalogListView.qmlsrc/musesounds/qml/MuseScore/MuseSounds/internal/SoundLibraryItem.qmlsrc/notationscene/qml/MuseScore/NotationScene/EditPercussionShortcutDialog.qmlsrc/notationscene/qml/MuseScore/NotationScene/PercussionPanelPadSwapDialog.qmlsrc/notationscene/qml/MuseScore/NotationScene/editpercussionshortcutmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/editpercussionshortcutmodel.hsrc/notationscene/qml/MuseScore/NotationScene/elementpopups/PartialTieMenuRowItem.qmlsrc/notationscene/qml/MuseScore/NotationScene/elementpopups/PartialTiePopup.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/AccidentalsPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/ChordSymbolsPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/ClefKeyTimeSigPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/ComboBoxDropdown.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/HammerOnPullOffTappingPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/IconAndTextButtonSelector.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/InstrumentNamesPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/LaissezVibrSection.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/MeasureNumbersPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/RadioButtonSelectorWithReset.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/SelectableStyledImage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/SlursAndTiesPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/SlursSection.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StaveSharingPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyleControlRowWithReset.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyleResetButton.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyleSpinboxWithReset.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyleToggle.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyleToggleWithImage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyledImage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/StyledXYControllerWithReset.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/TextFieldWithReset.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/TiesSection.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/VoltasPage.qmlsrc/notationscene/qml/MuseScore/NotationScene/styledialog/accidentalspagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/accidentalspagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/chordsymbolspagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/chordsymbolspagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/clefkeytimesigpagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/clefkeytimesigpagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/fretboardspagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/fretboardspagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/glissandosectionmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/glissandosectionmodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/hammeronpullofftappingpagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/hammeronpullofftappingpagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/instrumentnamespagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/instrumentnamespagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/measurenumberspagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/measurenumberspagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/measurerepeatmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/measurerepeatmodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/notelinesectionmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/notelinesectionmodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/repeatbarlinessectionmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/repeatbarlinessectionmodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/repeatplaycounttextmodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/repeatplaycounttextmodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/slursandtiespagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/slursandtiespagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/stavesharingpagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/stavesharingpagemodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/tupletcenteringselectormodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/tupletcenteringselectormodel.hsrc/notationscene/qml/MuseScore/NotationScene/styledialog/voltaspagemodel.cppsrc/notationscene/qml/MuseScore/NotationScene/styledialog/voltaspagemodel.hsrc/playback/qml/MuseScore/Playback/internal/KnobControl.qmlsrc/playback/qml/MuseScore/Playback/internal/MixerPanelToolbar.qmlsrc/playback/qml/MuseScore/Playback/internal/PlaybackSpeedPopup.qmlsrc/playback/qml/MuseScore/Playback/internal/VolumePressureMeter.qmlsrc/playback/qml/MuseScore/Playback/internal/VolumeSlider.qmlsrc/stubs/musesounds/musesamplercheckupdateservicestub.cppsrc/stubs/musesounds/musesoundscheckupdatescenariostub.cppsrc/stubs/musesounds/musesoundscheckupdatescenariostub.hsrc/stubs/musesounds/musesoundscheckupdateservicestub.cppsrc/stubs/musesounds/musesoundscheckupdateservicestub.hsrc/web/audioengine/webaudioengine.cppsrc/web/audioengine/webaudioengine.htools/miditools/midifile.htools/miditools/tempomap.htools/miditools/xmlreader.htools/miditools/xmlwriter.hversion.cmakevtest/README.md
💤 Files with no reviewable changes (1)
- SetupConfigure.cmake
…io where it was missing
c636d9c to
e46cc4a
Compare
Resolves: #32235
Finish renaming to Studio, now that there is a major version number change.
I have removed some compatibility CMake variables that were no longer necessary. The remaining changes are mostly file-headers and READMEs that had not yet been updated.
Most changes from the original issue had already been addressed before (such as the application name and the name of the user directories). The executable names have not been updated for any OS, so this PR contains no breaking changes in the end.
Related to: musescore/muse_framework#39