Add WebSocket datasource option for local ESP32 wireless workflows#1
Draft
musfaagv wants to merge 1 commit into
Draft
Add WebSocket datasource option for local ESP32 wireless workflows#1musfaagv wants to merge 1 commit into
musfaagv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WebSocketConfigand extendConnectionTypeto includewebsocket, and exposeconnectWebSocket(config)fromuseDataConnectionto open a socket and parse newline-delimited lines.useDataConnection, including graceful disconnects andwrite()routing to either serial or websocket.ConnectModalwith aWebSocket URLinput and aConnect WebSocketaction, and wireonConnectWebSocketthroughHeaderandApp.ConnectModalunit test and README usage instructions to document the ESP32 + local WebSocket server flow.Testing
npm test -- src/hooks/__tests__/useDataConnection.test.ts src/components/__tests__/ConnectModal.test.tsx, and both test files passed.npm run build, which completed successfully.npm test, and all tests passed (150 testsin the environment used).Codex Task