Fix multiple spotify connect instances reporting to the latest registered webservice callback #2905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered webservice callback os.environ was used to communicate the callback url to the librespot binary. When multiple instances are started simultaneously the env variable gets overwritten and only the last value was used. Now every librespot instance gets its own env variables instead of using the shared os.environ.
MarvinSchenkel
approved these changes
Jan 2, 2026
Contributor
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
There was a problem hiding this comment.
Awesome, thanks @kneirinck 🎉
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
…ered webservice callback (#2905) os.environ was used to communicate the callback url to the librespot binary. When multiple instances are started simultaneously the env variable gets overwritten and only the last value was used. Now every librespot instance gets its own env variables instead of using the shared os.environ.
MarvinSchenkel
pushed a commit
that referenced
this pull request
Jan 2, 2026
…ered webservice callback (#2905) os.environ was used to communicate the callback url to the librespot binary. When multiple instances are started simultaneously the env variable gets overwritten and only the last value was used. Now every librespot instance gets its own env variables instead of using the shared os.environ.
|
Same issue with trying to add Spotify and authenticate. I click the link "click here if the popup did not open". It opens authenticate.Spotify.com and I scroll down and select "agree". Then the browser pulls up a random page and Spotify is not setup. This is being done from IPhone. Running 2.8.0b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.environ was used to communicate the callback url to the librespot binary.
When multiple instances are started simultaneously the env variable gets overwritten and only the last value was used.
Now every librespot instance gets its own env variables instead of using the shared os.environ.