Refactor#3
Merged
Merged
Conversation
some small details left, ready for testing
OzGav
pushed a commit
that referenced
this pull request
May 12, 2026
Captures the design idea surfaced in conversation: a complementary Movements section on Work detail that transposes the same recordings into movement-grouped rows for cross-recording comparison. Reuses MA's existing collapsible-section pattern from Artists detail; hidden for single-movement Works; same data, different group-by. Recorded in Open Questions #3 as deferred to post-Stage 10 polish unless user demand surfaces, with full design (collapsible sections, default collapse state, single-movement hiding) captured so the implementer doesn't need to redesign from scratch when it's picked up.
OzGav
pushed a commit
that referenced
this pull request
May 12, 2026
iVolt1
added a commit
to iVolt1/server
that referenced
this pull request
May 12, 2026
3. PROBLEM — _register_plugin_queue always sets state: "playing" This is the same issue as your PENDING FIX 1 from the continuity doc — the fake queue always looks like it's playing. The fix is to track a _playback_state flag in the provider and pass the correct state into _register_plugin_queue. For issue music-assistant#3 track playback state in the provider so _register_plugin_queue can pass the correct state and a stable elapsed_time_last_updated when paused. Three changes from the input file: Line ~211 — added self._is_paused: bool = False Lines ~878–880 — added _is_paused state tracking block before the call_later, setting True on paused, False on playing/sink/track_changed Lines ~929–930 — elapsed_time_last_updated and state in fake_queue now use _is_paused instead of always being time.time() / "playing"
sandymac
added a commit
to sandymac/music-assistant-server
that referenced
this pull request
May 16, 2026
Resolves design-doc Q8 ("does docs/ ship upstream?") by folding the
design doc content into a provider-level README following the
established pattern (sendspin/README.md, local_audio/README.md,
hue_entertainment/README.md, etc.). The top-level docs/ tree is removed.
music_assistant/providers/wled_audiosync/README.md (new):
- Concise reference rather than dev-history doc: drops the phasing
plan and prior "open questions" framing, keeps everything users
and reviewers actually need.
- Sections:
* Clean-room declaration (prominent — Apache-2.0 vs GPL-3.0
reference projects).
* In scope / out of scope.
* Architecture diagram showing PCM → DSP → encoder → UDP fan-out.
* File map of the provider directory.
* Discovery flow (mDNS + /json/info filter + port-pinning quirk).
* Provider-level + per-Player config tables.
* V2 packet wire format (44 bytes, why 44 not 40, struct.pack form).
* DSP pipeline ASCII diagram + defaults table.
* Implementation notes worth recording (the architectural decisions
that emerged during implementation - global vs per-band AGC, the
mDNS-port quirk, sender-side IP_ADD_MEMBERSHIP, the TransportSocket
gotcha, auto-reset + /json/info re-probe, AudioReactive detection).
* Test inventory matching the 98 tests / 92% coverage state.
* Hardware-in-loop verification procedure (rewritten to not depend
on Sandy's local-disk wled_test_tones path; references the
in-test generators in test_dsp_frequency_mapping.py instead).
* Open design questions still needing maintainer review (music-assistant#2, music-assistant#3, music-assistant#9,
music-assistant#10, music-assistant#11, music-assistant#12 - Q1, Q4, Q5, Q6, Q7, Q8 are all closed now).
docs/wled_audiosync_design.md: removed.
CLAUDE.local.md:
- "Pointers" section now references the README path.
- Resolved-questions list adds Q8 ("PR scope / docs/ tree") as closed
by this move.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sandymac
added a commit
to sandymac/music-assistant-server
that referenced
this pull request
May 18, 2026
Resolves design-doc Q8 ("does docs/ ship upstream?") by folding the
design doc content into a provider-level README following the
established pattern (sendspin/README.md, local_audio/README.md,
hue_entertainment/README.md, etc.). The top-level docs/ tree is removed.
music_assistant/providers/wled_audiosync/README.md (new):
- Concise reference rather than dev-history doc: drops the phasing
plan and prior "open questions" framing, keeps everything users
and reviewers actually need.
- Sections:
* Clean-room declaration (prominent — Apache-2.0 vs GPL-3.0
reference projects).
* In scope / out of scope.
* Architecture diagram showing PCM → DSP → encoder → UDP fan-out.
* File map of the provider directory.
* Discovery flow (mDNS + /json/info filter + port-pinning quirk).
* Provider-level + per-Player config tables.
* V2 packet wire format (44 bytes, why 44 not 40, struct.pack form).
* DSP pipeline ASCII diagram + defaults table.
* Implementation notes worth recording (the architectural decisions
that emerged during implementation - global vs per-band AGC, the
mDNS-port quirk, sender-side IP_ADD_MEMBERSHIP, the TransportSocket
gotcha, auto-reset + /json/info re-probe, AudioReactive detection).
* Test inventory matching the 98 tests / 92% coverage state.
* Hardware-in-loop verification procedure (rewritten to not depend
on Sandy's local-disk wled_test_tones path; references the
in-test generators in test_dsp_frequency_mapping.py instead).
* Open design questions still needing maintainer review (music-assistant#2, music-assistant#3, music-assistant#9,
music-assistant#10, music-assistant#11, music-assistant#12 - Q1, Q4, Q5, Q6, Q7, Q8 are all closed now).
docs/wled_audiosync_design.md: removed.
CLAUDE.local.md:
- "Pointers" section now references the README path.
- Resolved-questions list adds Q8 ("PR scope / docs/ tree") as closed
by this move.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.