Skip to content

AcoustID Skip processing if track has an ISRC#4022

Merged
OzGav merged 3 commits into
devfrom
OzGav-patch-1
May 30, 2026
Merged

AcoustID Skip processing if track has an ISRC#4022
OzGav merged 3 commits into
devfrom
OzGav-patch-1

Conversation

@OzGav
Copy link
Copy Markdown
Contributor

@OzGav OzGav commented May 29, 2026

Add check for existing ISRC before processing track.

What does this implement/fix?

Need to skip processing if an ISRC is present

Related issue (if applicable):

  • related issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • New music/player/metadata/plugin provider — new-provider
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — documentation
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pre-commit run --all-files passes.
  • pytest passes, and tests have been added/updated under tests/ where applicable.
  • For changes to shared models, the companion PR in music-assistant/models is linked.
  • For changes affecting the UI, the companion PR in music-assistant/frontend is linked.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.

Add check for existing ISRC before processing track.
@OzGav OzGav changed the title Skip processing if track has an ISRC AcoustID Skip processing if track has an ISRC May 29, 2026
@MarvinSchenkel MarvinSchenkel enabled auto-merge (squash) May 29, 2026 10:44
@MarvinSchenkel
Copy link
Copy Markdown
Contributor

Good improvement but the tests need to be updated

@OzGav OzGav marked this pull request as draft May 30, 2026 03:48
auto-merge was automatically disabled May 30, 2026 03:48

Pull request was converted to draft

@OzGav OzGav marked this pull request as ready for review May 30, 2026 11:55
@OzGav OzGav merged commit e4f5af0 into dev May 30, 2026
10 checks passed
@OzGav OzGav deleted the OzGav-patch-1 branch May 30, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants