Skip to content

Hide HTTP profile and ICY metadata config entries for Samsung WAM#4045

Merged
OzGav merged 2 commits into
music-assistant:devfrom
Oliver-Stevens:fix/samsung-wam-config-entries
Jun 1, 2026
Merged

Hide HTTP profile and ICY metadata config entries for Samsung WAM#4045
OzGav merged 2 commits into
music-assistant:devfrom
Oliver-Stevens:fix/samsung-wam-config-entries

Conversation

@Oliver-Stevens
Copy link
Copy Markdown
Contributor

What does this implement/fix?

Hides the HTTP profile config entry (WAM requires Profile 3 for URL streaming; other profiles break playback) and ICY metadata entry (not applicable to WAM hardware).
Also updates the provider name to "Samsung WAM" and fixes the documentation URL (samsung_wamsamsung-wam).

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • New music/player/metadata/plugin provider — new-provider
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — documentation
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pre-commit run --all-files passes.
  • pytest passes, and tests have been added/updated under tests/ where applicable.
  • For changes to shared models, the companion PR in music-assistant/models is linked.
  • For changes affecting the UI, the companion PR in music-assistant/frontend is linked.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.

@github-actions
Copy link
Copy Markdown
Contributor

🔒 Dependency Security Report

✅ No dependency changes detected in this PR.

Copy link
Copy Markdown
Contributor

@OzGav OzGav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OzGav OzGav merged commit 8fa7ff2 into music-assistant:dev Jun 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants