Skip to content

Comments

adding source files for example images #187

Merged
kepper merged 42 commits intomusic-encoding:masterfrom
rettinghaus:develop
Oct 29, 2020
Merged

adding source files for example images #187
kepper merged 42 commits intomusic-encoding:masterfrom
rettinghaus:develop

Conversation

@rettinghaus
Copy link
Member

This PR adds all the source MEI files that I used to create the new/changed example images in the Guidelines.
There is script in there as well, that renders all examples with LilyPond and puts the png into the ExampleImages folder.

I added the examples to the dev version as well, without the script/xslt, as we probably want to have another approach there when moving the guidelines back to odd.

@rettinghaus rettinghaus requested a review from kepper September 25, 2020 16:04
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very useful. However, I'm inclined to not merge it right now, but instead reconsider this in the light of the new setup of the specs and guidelines being merged into one repo. Let's put this on hold for a little time, and see where the best place for this material is…

@rettinghaus
Copy link
Member Author

@kepper I'm ok with waiting, but as described above, for the development version there are only the source files in for now, so we can see how we integrate them in the new build process, whereas I think we will keep older versions of the guidelines basically static.

@rettinghaus
Copy link
Member Author

As discussed on ODD meeting the script has been moved to the tools folder and a README has been added.

Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, @rettinghaus 👍

@kepper kepper merged commit 01c865b into music-encoding:master Oct 29, 2020
@rettinghaus rettinghaus deleted the develop branch December 17, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants