Skip to content

Comments

Fix broken model links in v4#205

Merged
musicEnfanthen merged 2 commits intomusic-encoding:mainfrom
rettinghaus:fix/links
Jul 29, 2022
Merged

Fix broken model links in v4#205
musicEnfanthen merged 2 commits intomusic-encoding:mainfrom
rettinghaus:fix/links

Conversation

@rettinghaus
Copy link
Member

@rettinghaus rettinghaus commented Jun 22, 2022

This fixes some broken links in the Guidelines.
Closes music-encoding/music-encoding#979

@musicEnfanthen musicEnfanthen changed the title fix links in v4 Fix broken model links in v4 Jun 23, 2022
@musicEnfanthen
Copy link
Member

Thank you @rettinghaus for the fix. [Hope you don't mind if I changed the title to a more speaking one for future reference.]

@kepper There seemed to be some issue with link generation for model links. We should double check that these links are correctly generated in the upcoming guideline versions.

@musicEnfanthen
Copy link
Member

@rettinghaus
There seems to be another one in:

<a href="/guidelines/v4/model-classes/model.model.pubstmtpart.html">model.model.pubStmtPart</a> class. The following elements may be used to provide details regarding the file’s publication and distribution:</p>

@rettinghaus
Copy link
Member Author

Thanks, @musicEnfanthen ! Should be fixed now.

@musicEnfanthen
Copy link
Member

Merged at ODD meeting (July 2022). Thanks @rettinghaus for the fix and @apacha for reporting.

@musicEnfanthen musicEnfanthen merged commit 62a0994 into music-encoding:main Jul 29, 2022
@rettinghaus rettinghaus deleted the fix/links branch July 29, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some links in "Shared Concepts" documentation are broken

2 participants