Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors how query tracing is configured for the PostgreSQL pool, and adds an option to set the password independently.
Changes:
- Switch
optfrom holding a*tracerto embedding atracervalue and set tracer fields directly via options. - Update pool creation to wire tracing when either a
TraceFnor OTEL tracer is configured. - Add
WithPasswordoption; remove exportedNewTracer/NewOTELTracerconstructors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tracer.go | Removes exported tracer constructors, leaving tracer configuration to options/field assignment. |
| pool.go | Updates tracer wiring logic to handle TraceFn and OTEL tracer configuration. |
| opts.go | Refactors tracer storage in options, adds WithPassword, and adjusts WithTrace/WithTracer to set tracer fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the tracing functionality in the connection options and pool setup code. The main focus is to simplify how tracers are managed by removing pointer usage, consolidating tracer initialization, and improving how trace functions and OTEL tracers are wired up. Additionally, a new option for setting only the password is introduced.
Tracing refactor and simplification
optstruct to hold a value oftracerinstead of a pointer, and updated initialization to use a value (opts.go) [1] [2].NewTracerandNewOTELTracerconstructor functions, and updatedWithTraceandWithTracerto directly set fields on thetracerstruct (tracer.go,opts.go) [1] [2].poolconfig.ConnConfig.Traceras needed (pool.go).Option improvements
WithPasswordoption to set the connection password independently from username and database (opts.go).