Conversation
… with enhanced validation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 442a12a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ask-questionsshape, can provide answer options--waitoption for all robots jobs to wait til the job is done -- same thing we do for asset createNote
Medium Risk
Touches multiple robots CLI commands and changes parameter parsing/validation and output behavior (including polling/waiting), so regressions could break existing CLI usage, but changes are confined to client-side command wiring.
Overview
Adds shared helpers in
robots/_shared.tsto load job parameters from a JSON file, poll for job completion (--wait), and standardize workflow/job retrieval and terminal-status handling (with clearer failure messages viaassertJobCompleted).Updates all Robots job creation commands to support
-f/--file(mutually exclusive with individual parameter flags) and--waitto poll up to 15 minutes, printing outputs on completion and failing fast onerrored/cancelled. Also improves input validation (e.g.,summarize --toneenum validation,find-key-moments --max-momentsrange checks,moderatethresholds parsing/range checks) and extendsask-questionsto parse--questionstrings with optional answer options (text|opt1,opt2).Refactors
robots getto reuse shared workflow validation andretrieveRobotsJob, and expands unit tests across commands to cover new flags, file-mode errors, and validation.Reviewed by Cursor Bugbot for commit 06bfb77. Bugbot is set up for automated code reviews on this repo. Configure here.