Skip to content

Polish up some robots commands#67

Merged
dylanjha merged 4 commits intomainfrom
dj/robots-polish
Apr 16, 2026
Merged

Polish up some robots commands#67
dylanjha merged 4 commits intomainfrom
dj/robots-polish

Conversation

@dylanjha
Copy link
Copy Markdown
Contributor

@dylanjha dylanjha commented Apr 16, 2026

  • work with the new ask-questions shape, can provide answer options
  • accept -f / --file convention for all robots jobs -- same thing we do for asset create
  • accept --wait option for all robots jobs to wait til the job is done -- same thing we do for asset create

Note

Medium Risk
Touches multiple robots CLI commands and changes parameter parsing/validation and output behavior (including polling/waiting), so regressions could break existing CLI usage, but changes are confined to client-side command wiring.

Overview
Adds shared helpers in robots/_shared.ts to load job parameters from a JSON file, poll for job completion (--wait), and standardize workflow/job retrieval and terminal-status handling (with clearer failure messages via assertJobCompleted).

Updates all Robots job creation commands to support -f/--file (mutually exclusive with individual parameter flags) and --wait to poll up to 15 minutes, printing outputs on completion and failing fast on errored/cancelled. Also improves input validation (e.g., summarize --tone enum validation, find-key-moments --max-moments range checks, moderate thresholds parsing/range checks) and extends ask-questions to parse --question strings with optional answer options (text|opt1,opt2).

Refactors robots get to reuse shared workflow validation and retrieveRobotsJob, and expands unit tests across commands to cover new flags, file-mode errors, and validation.

Reviewed by Cursor Bugbot for commit 06bfb77. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/commands/robots/find-key-moments.ts Outdated
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 442a12a. Configure here.

Comment thread src/commands/robots/_shared.ts
@dylanjha dylanjha merged commit 1bb4ba0 into main Apr 16, 2026
8 checks passed
@dylanjha dylanjha deleted the dj/robots-polish branch April 16, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant